Skip to content

[Manual backport 2.8] Adds the newly created admin api permissions to the static dropdown list (#1446)#1452

Closed
RyanL1997 wants to merge 3 commits intoopensearch-project:2.8from
RyanL1997:manual-backport-1446-to-2.8
Closed

[Manual backport 2.8] Adds the newly created admin api permissions to the static dropdown list (#1446)#1452
RyanL1997 wants to merge 3 commits intoopensearch-project:2.8from
RyanL1997:manual-backport-1446-to-2.8

Conversation

@RyanL1997
Copy link
Copy Markdown
Collaborator

@RyanL1997 RyanL1997 commented May 31, 2023 •
edited
Loading

Description

Manual backport #1446 because the CI failed 7 times in a row due to the flaky test case of SAML.

Issues Resolved

Reference

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 changed the title Manual backport #1446 and #1449 [Manual backport 2.8] #1446 and #1449 May 31, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #1452 (39e37ca) into 2.8 (6b09aee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.8    #1452   +/-   ##
=======================================
  Coverage   65.51%   65.51%           
=======================================
  Files          93       93           
  Lines        2294     2294           
  Branches      312      312           
=======================================
  Hits         1503     1503           
  Misses        723      723           
  Partials       68       68
Impacted Files Coverage Δ
public/apps/configuration/constants.tsx 86.20% <ø> (ø)

@RyanL1997 RyanL1997 force-pushed the manual-backport-1446-to-2.8 branch from 751698b to 1531d6a Compare May 31, 2023 01:47
@RyanL1997 RyanL1997 changed the title [Manual backport 2.8] #1446 and #1449 [Manual backport 2.8] #1446 May 31, 2023
@RyanL1997
Manual backport opensearch-project#1446
37b7497 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997 RyanL1997 force-pushed the manual-backport-1446-to-2.8 branch from 1531d6a to 37b7497 Compare May 31, 2023 01:51
@cwperks cwperks changed the title [Manual backport 2.8] #1446 [Manual backport 2.8] Adds the newly created admin api permissions to the static dropdown list (#1446) May 31, 2023
@cwperks
Copy link
Copy Markdown
Member

cwperks commented May 31, 2023

@RyanL1997 Do you think we should add the changes from this PR to this branch as well?

@RyanL1997
Copy link
Copy Markdown
Collaborator Author

RyanL1997 commented May 31, 2023

@cwperks I think this one has been merged: #1449

@RyanL1997 RyanL1997 mentioned this pull request May 31, 2023
Merged
3 tasks
@RyanL1997
Bypass tenancy presistace test case in saml integ test
f3da3ae 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Copy Markdown
Collaborator Author

RyanL1997 commented May 31, 2023 •
edited
Loading

@opensearch-project/security
Note: since the original PR was failing 11 times in a row... :( I created this manual backport PR and bypassing the flaky saml test case. For the failing of Prerequisite Check, it just happened now, I think this is because the build of security plugin of version 2.8.0 is expired. However, since we are using maven snapshot for all the test cases, I think it is reasonable for us to remove this Prerequisite Check workflow.

@RyanL1997
Removing Prerequisite Checks Workflow
39e37ca 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Copy Markdown
Collaborator Author

RyanL1997 commented May 31, 2023 •
edited
Loading

Update: I just removed the latest Prerequisite Check workflow due to this error:

Run wget -S --spider [https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/${opensearch_version}/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-security-${opensearch_security_plugin_version}.zip](https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/$%7Bopensearch_version%7D/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-security-$%7Bopensearch_security_plugin_version%7D.zip) || (echo "Please make sure security plugin has been bumped to the same version and added to manifest." && exit 1)
Spider mode enabled. Check if remote file exists.
--2023-05-31 05:15:41--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.8.0/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-security-2.8.0.0.zip
Resolving ci.opensearch.org (ci.opensearch.org)... 18.155.202.114, 18.155.202.115, 18.155.202.2, ...
Connecting to ci.opensearch.org (ci.opensearch.org)|18.155.202.114|:443... connected.
HTTP request sent, awaiting response... 
  HTTP/1.1 302 Moved Temporarily
  Content-Length: 0
  Connection: keep-alive
  Server: CloudFront
  Date: Wed, 31 May 2023 05:15:42 GMT
  Location: /ci/dbc/distribution-build-opensearch/2.8.0/[7](https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/5129141429/jobs/9226482794?pr=1452#step:2:8)917/linux/x64/tar/builds/opensearch/plugins/opensearch-security-2.8.0.0.zip
  Cache-Control: max-age=3600
  X-Cache: Miss from cloudfront
  Via: 1.1 cb0b891eddf58d69d157d55977c68bce.cloudfront.net (CloudFront)
  X-Amz-Cf-Pop: SFO53-P2
  X-Amz-Cf-Id: -ujlaolQ5hjQRoJ39spDGSjtkhDCf5HPekdmrzEqjd6Q2GOcoCj9uA==
Location: /ci/dbc/distribution-build-opensearch/2.8.0/7917/linux/x64/tar/builds/opensearch/plugins/opensearch-security-2.8.0.0.zip [following]
Spider mode enabled. Check if remote file exists.
--2023-05-31 05:15:42--  https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.[8](https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/5129141429/jobs/9226482794?pr=1452#step:2:9).0/7[9](https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/5129141429/jobs/9226482794?pr=1452#step:2:10)17/linux/x64/tar/builds/opensearch/plugins/opensearch-security-2.8.0.0.zip
Connecting to ci.opensearch.org (ci.opensearch.org)|18.155.202.114|:443... connected.
HTTP request sent, awaiting response... 
  HTTP/1.1 403 Forbidden
  Content-Type: application/xml
  Connection: keep-alive
  Date: Wed, 31 May 2023 05:[15](https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/5129141429/jobs/9226482794?pr=1452#step:2:16):42 GMT
  Server: AmazonS3
  X-Cache: Error from cloudfront
  Via: 1.1 ab6fdf5fb[19](https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/5129141429/jobs/9226482794?pr=1452#step:2:20)9d6495c32e485c23f5728.cloudfront.net (CloudFront)
  X-Amz-Cf-Pop: SFO53-P2
  X-Amz-Cf-Id: fBmf8B9LYiSEakJL9TwWyORqLoRPkJr9r2ZYPESdEmlkfTFHqGgIlQ==
Remote file does not exist -- broken link!!!

Please make sure security plugin has been bumped to the same version and added to manifest.
Error: Process completed with exit code 1.

@RyanL1997
Copy link
Copy Markdown
Collaborator Author

RyanL1997 commented May 31, 2023 •
edited
Loading

Closing this due to the merge of #1446 (Yep, the flaky test is passing on its 12th attempt...). However, we may still remove the Prerequisite Check for future. I can do a follow up PR if we need it.

@RyanL1997 RyanL1997 closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwperks cwperks cwperks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RyanL1997 @cwperks